cobra icon indicating copy to clipboard operation
cobra copied to clipboard

Published 20 hours ago • verified publisher icon spf13

fix(bash): Fix bash completion for suggestions that contain special characters.

Open JeffFaer opened this issue 11 months ago • 2 comments

Special characters include whitepace, so this is more general than #1743. This should also fix #1740.

I added some test cases to cobra-completion-testing. This PR makes them pass. It also doesn't trip any of the performance regression tests. I'm happy to submit those tests as a PR as well.

  • https://github.com/JeffFaer/cobra-completion-testing/tree/special_characters
  • https://github.com/JeffFaer/cobra-completion-testing/commit/52254c1a25b9816cf31a617cf9667e61a1bd2259

JeffFaer avatar Mar 21 '24 04:03 JeffFaer

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 21 '24 04:03 CLAassistant

It would be nice to have this PR merged - many rclone users have noticed that we can't complete file names with spaces in :-(

ncw avatar Sep 06 '24 17:09 ncw