cobra icon indicating copy to clipboard operation
cobra copied to clipboard

Update golangci configuration

Open umarcor opened this issue 2 years ago • 3 comments

umarcor avatar Aug 22 '22 00:08 umarcor

Thanks @umarcor, can you provide details on why you had/chose to make these changes? Thanks

marckhouzam avatar Aug 30 '22 01:08 marckhouzam

@marckhouzam I just applied the "defaults" as currently documented in https://golangci-lint.run/usage/linters/. I enabled the ones listed in https://golangci-lint.run/usage/linters/#enabled-by-default, which were not enabled here. By the way, I cleaned up the ones marked as "no longer maintained" or "replaced by".

umarcor avatar Aug 30 '22 17:08 umarcor

@marckhouzam also, the makefile was modified because gofmt is now enabled in the golangci-lint configuration. Hence, it is redundant to run it independently.

umarcor avatar Aug 30 '22 17:08 umarcor