cobra icon indicating copy to clipboard operation
cobra copied to clipboard

style(bash-v2): various cleanups

Open scop opened this issue 2 years ago • 6 comments

Here's a bunch of bash code cleanups I made on the side while working on the performance improvements. See individual commits and messages for details. Some of these are also performance improvements in principle in addition to stylistic ones, but I believe they're not on any hot path so that side is negligible.

Some of these might be a bit opinionated/subjective but read the way I'd personally put them, let me know if you'd rather not make some of these changes and I'll follow suit.

scop avatar May 17 '22 21:05 scop

Just an update that I haven't forgot about this, I'm just having trouble with my setup (waiting on a new computer). I will get back to this as soon as I can.

marckhouzam avatar Jun 01 '22 21:06 marckhouzam

Sure, no rush at all as far as I'm concerned, take all the time you like :+1:

scop avatar Jun 02 '22 06:06 scop

@scop Finally getting back to this but the PR now has conflicts 😞 Could you rebase when you have a moment?

marckhouzam avatar Jun 18 '22 16:06 marckhouzam

Reworked and still untested, hopefully I didn't add too many bugs.

scop avatar Jun 18 '22 20:06 scop

Reworked and still untested, hopefully I didn't add too many bugs.

Thanks @scop. After looking at this one again, I suggest changing our strategy. Since this is a cleanup and not an actual fix, and that there will be a Cobra release soon, let's play it safe and wait on this one until after the release so we can get some more soak time.

marckhouzam avatar Jun 20 '22 11:06 marckhouzam

Rebased.

scop avatar Aug 19 '22 15:08 scop

I'm going to merge this improvement now to give it a lot of soak time until the next release.

marckhouzam avatar Oct 17 '22 19:10 marckhouzam