cobra icon indicating copy to clipboard operation
cobra copied to clipboard

Published 20 hours ago • verified publisher icon spf13

feat(command): adding args to use line

Open danmx opened this issue 3 years ago • 9 comments

Adding args to use line

danmx avatar Aug 27 '20 07:08 danmx

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 27 '20 07:08 CLAassistant

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar Oct 27 '20 00:10 github-actions[bot]

@jpmcb could you take a look?

danmx avatar Oct 27 '20 09:10 danmx

Ref #842

umarcor avatar Oct 27 '20 23:10 umarcor

Hi @danmx thanks for this PR - would you be able to add a test for this? Maybe in command_test.go? A passing test will help this get reviewed and merged in

jpmcb avatar Dec 29 '20 15:12 jpmcb

@jpmcb took me some time but I've added tests for UseLine.

danmx avatar Sep 24 '23 16:09 danmx

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Sep 24 '23 19:09 github-actions[bot]

@marckhouzam I see that you were active recently. Could you take a look at this PR?

I addressed the previous comment about adding tests. I had to reshuffle Command struct optimal memory usage (fixing violations of maligned linter) because I added another bool field.

danmx avatar Oct 01 '23 09:10 danmx

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 17 '23 11:10 github-actions[bot]