cobra icon indicating copy to clipboard operation
cobra copied to clipboard

Copy parsed flag values when constructing `LocalFlags()`

Open bcongdon opened this issue 5 years ago • 4 comments

This checks in the failing test that #1019 references, and proposes a fix to LocalFlags() not copying information about whether a flag has been parsed or not.

If preferable, I can open a PR against spf13/pflag to change flagSet.AddFlag to copy the fact that a flag already has a value instead of performing that logic here.

bcongdon avatar Jan 16 '20 03:01 bcongdon

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 06 '20 11:03 CLAassistant

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar May 06 '20 00:05 github-actions[bot]

Pinging this, CLA is signed

bcongdon avatar May 08 '20 00:05 bcongdon

I'm so sorry its taken so long to respond to this PR. We are actively trying to tackle the backlog.

johnSchnake avatar Feb 21 '22 18:02 johnSchnake