cobra icon indicating copy to clipboard operation
cobra copied to clipboard

Add groups for commands in help

Open aawsome opened this issue 5 years ago • 26 comments

Adds the possibility to group the commands in the help message.

closes #836 closes #1271

aawsome avatar Dec 14 '19 13:12 aawsome

@aawsome I think this is a good addition. It's something I can put on the roadmap after 1.0.0 is released.

jharshman avatar Dec 23 '19 03:12 jharshman

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 06 '20 11:03 CLAassistant

Any updates on this? or any workarounds exist?

mhewedy avatar Apr 25 '20 22:04 mhewedy

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar Jul 08 '20 00:07 github-actions[bot]

I rebased this PR. Now that 1.0.0 is out, is there anything I can do to get this PR merged?

aawsome avatar Jul 08 '20 07:07 aawsome

@aawsome Maybe we can nudge @jharshman for some visibility. I think should be able to provide some direction.

itskingori avatar Jul 08 '20 10:07 itskingori

@aawsome would you mind adding some tests for this feature?

umarcor avatar Jul 08 '20 13:07 umarcor

Added some tests. Almost all new code is covered by these tests.

The exception is AddCommandGroup when helpCommand is manually set. (In this case most people would anyway directly specify the Group within the Command definition)

aawsome avatar Jul 08 '20 19:07 aawsome

Is there anything I can do to help getting this PR merged?

aawsome avatar Jul 19 '20 17:07 aawsome

This has been open for a while and would be pretty nice to have this merged. Any chance anyone could have a look at it?

nacx avatar Feb 07 '21 17:02 nacx

@aawsome Branch has conflicts. Could you rebase? So that if it's ready by the time @jharshman has a another look?

itskingori avatar Feb 08 '21 04:02 itskingori

@aawsome Branch has conflicts. Could you rebase? So that if it's ready by the time @jharshman has a another look?

is rebased.

aawsome avatar Feb 08 '21 08:02 aawsome

Hey, Any updates regarding this feature?

yuvalsosman avatar Oct 11 '21 15:10 yuvalsosman

@yuvalsosman, see #1496.

umarcor avatar Oct 11 '21 15:10 umarcor

Also close https://github.com/spf13/cobra/issues/1271

MichaelMure avatar Oct 29 '21 06:10 MichaelMure

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar Feb 07 '22 00:02 github-actions[bot]

What's blocking this from being merged?

codyaray avatar Feb 10 '22 19:02 codyaray

From my side, I'm fine with getting this merged. Actually realized that this PR is now waiting now for more than two years - that's quite some time...

Anyhow, if there is anything I can do, please tell me!

aawsome avatar Feb 10 '22 22:02 aawsome

@jpmcb Any chance you could look at this?

itskingori avatar Feb 14 '22 13:02 itskingori

Hi all - thanks for the ping, sorry this got so stale!

This looks like something the community has alot of support for, so let's get this in on the next release! 🌠 Will plan to review and merge soon

jpmcb avatar Feb 14 '22 15:02 jpmcb

Hi, Happy to see this PR is going to be released soon, do you have some estimation of when this feature will be available?

yuvalsosman avatar Feb 16 '22 13:02 yuvalsosman

@aawsome Seems we are ready to go, but you might have to solve the conflicts first.

RainbowMango avatar Mar 10 '22 07:03 RainbowMango

I rebased and fixed the test that was failing bacause of the automatically-added completion command.

This PR should be now ready for merging.

aawsome avatar Mar 10 '22 08:03 aawsome

@marckhouzam @jpmcb Sorry to ping, but can we get this merged now?

ssoroka avatar Mar 16 '22 19:03 ssoroka

@ssoroka see #1626.

umarcor avatar Mar 16 '22 21:03 umarcor

Sorry if this sounds rude.

This PR is now open for 2 1/2 years. I always almost immediately answered to any question or request. Which was in last history mostly rebasing because of code changes in master. This PR was on the roadmap for 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.5.0 (or maybe not for all, but I'm not connected to release planing). Sorry, but this is really annoying!

I'm not working seriously with go for about one year now. This PR is still mergeable. @maintainers: Please decide if you like to merge this PR or close it if not. When the next request for rebasing comes I might simply close it instead of investing (most likely wasted) work into this PR.

aawsome avatar Jun 24 '22 04:06 aawsome

@marckhouzam @jpmcb adding to the next milestone has occurred numerous times over the 2.5 years this PR has been open. Many of us would like to see this merged so we can stop maintaining forks, and or ugly templating hacks.

fruitbutt avatar Sep 27 '22 14:09 fruitbutt

@fruitbutt see https://github.com/spf13/cobra/blob/main/MAINTAINERS. You might want to ping maintainers listed as non-inactive.

umarcor avatar Sep 27 '22 15:09 umarcor

Hi all - I'm sorry (again) this PR has gotten stale and I understand your frustration; I really do. I've been trying now for years to get the different places I've worked at to support me and my work for this extremely important open source project.

But, long story short, it all comes down to time; I just have no time to support this project on my own and the companies I've worked for are not interested in allocating any of my time to cobra. But it often feels like if I don't, no one else will, and I deeply fear what could happen if this project falls into disarray. If you didn't know already, cobra is a core dependency in Kubernetes, Helm, Tanzu, Cluster API, Linkerd, Grafana, Istio, etc. etc. and sits at a really important intersection of the Go software supply chain. This is generally why my posture towards new changes is a hesitant one.

So, I give corba what little extra time I have in order to ensure we don't have another faker.js situation on our hands.

Please don't take your frustration out on the maintainers; we are doing our best with what few resources we have but we understand how frustrating this is for the Go community. If we should be frustrated at anyone, it's the endless number of companies that are more than happy to consume these open source libraries while not giving back.


I will make this a priority for the next release which I hope to cut within the next few weeks. Thanks all.

jpmcb avatar Sep 27 '22 16:09 jpmcb

Maybe not introducing any relevant change for years in order to satisfy the needs of all those big companies gave the idea that they don't need to care about this project, because maintainers will take care of gatekeeping potential problems (even in development). I don't mean John's employers only, since this was happening far before he joined the project. Should the project evolve as an open source project which is not funded by any of those companies, maybe they would understand the need to do so.

umarcor avatar Sep 28 '22 06:09 umarcor