cobra-cli icon indicating copy to clipboard operation
cobra-cli copied to clipboard

Published 20 hours ago • verified publisher icon spf13

Bump to 2023 year in testdata

Open ivankovnatsky opened this issue 2 years ago • 7 comments

Close #63.

ivankovnatsky avatar Jan 20 '23 09:01 ivankovnatsky

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 20 '23 09:01 CLAassistant

CI is failing fort other reasons. Sigh... We'll need to clean this up.

marckhouzam avatar Jan 20 '23 17:01 marckhouzam

Can this be fixed permanently with Replace of current year to "{current_year}" on both sides before comparison? The periodic fixes are problematic for distros which run tests when building the package. For example I'm disabling the tests in Nixpkgs, because the build starts failing even though the software doesn't change https://hydra.nixos.org/build/207401170/nixlog/2 https://github.com/NixOS/nixpkgs/pull/214715

viraptor avatar Feb 05 '23 09:02 viraptor

Can this be fixed permanently with Replace of current year to "{current_year}" on both sides before comparison? The periodic fixes are problematic for distros which run tests when building the package.

I agree we need a better approach. However allowing the tests to pass would prevent user from remembering these files need to be changed. But I haven't looked at the code in a while so I might be missing something.

marckhouzam avatar Feb 05 '23 13:02 marckhouzam

Such a failure sounds suitable for your CI (upstream), but I think basically anyone else will be unhappy with that breakage. There are situations when even older versions are desirable to use (e.g. bisecting regressions across history) and then similar newly-appearing failures can be annoying.

vcunat avatar Feb 18 '23 10:02 vcunat

Damn it, I was cleaning up some public forked repos.

ivankovnatsky avatar Mar 21 '23 10:03 ivankovnatsky

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar May 21 '23 00:05 github-actions[bot]