cobra-cli icon indicating copy to clipboard operation
cobra-cli copied to clipboard

Rename configuration file to cobra-cli.yaml

Open marckhouzam opened this issue 3 years ago • 12 comments

During the discussion about creating the cobra-cli repo @spf13 hinted that we should rename the configuration file to cobra-cli.yaml but keep supporting the cobra.yaml name as a fallback. Please see https://github.com/spf13/cobra/issues/1597#issuecomment-1035220474

This PR does this. If a different approach is preferred, just let me know.

/cc @liggitt @jpmcb

marckhouzam avatar Feb 23 '22 02:02 marckhouzam

LGTM to me. Since its a behavior change on before a release I'll defer the merging to the (already) tagged folks.

johnSchnake avatar Feb 23 '22 03:02 johnSchnake

Thanks @liggitt for realizing that I missed the dot-prefix for all the config file references!

marckhouzam avatar Feb 23 '22 19:02 marckhouzam

Should we go ahead and merge this since the v1.3.0 release is done?

marckhouzam avatar Mar 15 '22 14:03 marckhouzam

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar May 17 '22 00:05 github-actions[bot]

@marckhouzam cmd/root.go was modified in https://github.com/spf13/cobra-cli/commit/9e07cb5c0d61dd7b020a4235889c8e1072dd93ab. Do you mind rebasing this PR?

umarcor avatar May 17 '22 08:05 umarcor

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar Sep 28 '22 00:09 github-actions[bot]

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar Nov 29 '22 00:11 github-actions[bot]

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar Jan 30 '23 00:01 github-actions[bot]

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar Apr 02 '23 00:04 github-actions[bot]

This PR is being marked as stale due to a long period of inactivity

github-actions[bot] avatar Jun 02 '23 00:06 github-actions[bot]

@marckhouzam - if you're feeling good with this one, let's go ahead and merge it 👀

jpmcb avatar Jun 23 '23 02:06 jpmcb

Thanks @jpmcb. I'll rebase then merge

marckhouzam avatar Jun 23 '23 11:06 marckhouzam