cobra-cli
cobra-cli copied to clipboard
spf13
Check if LICENSE exists.
In continuation to PR #1605
Signed off by: Harjyot Bagga [email protected] PR to resolve Issue https://github.com/spf13/cobra-cli/issues/39
- Checks if a LICENSE exists in the Project Directory, if so it lists and asks the user if they want to still add another LICENSE.
- If LICENSE exists, confirms if the user wishes to over-write the existing LICENSE.
- Changed default LICENSE to be LICENSE["empty"] instead of LICENSE["none"]
- LICENSE["none"] would be used if a user is unwilling to create a license.
Commands:
To create a project with no LICENSE:
cobra init proj-name -l none
In case of existing LICENSE:
Post Checks:
- [x] Built Successfully
- [x] All tests passed successfully
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
harjyotbagga seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
LGTM; built locally and overwrites it when I say 'y', doesn't otherwise.
Going to ping someone else for final merging only because of the change of default license; being new to the project I want to be extra cautious about that.
@jpmcb Can you confirm if changing the default license to empty is appropriate? E.g. default to leaving the license files alone. Maybe a nit would be naming; would ignore or something else be more appropriate? Functionality here seems fine though.
I was thinking on similar lines, but as far I remember I came across an issue in cobra suggesting to keep an empty license as the default one.
However I am up for anything.
Sure. Whenever that's done, we can add this feature. If there are any changes to be done from my end, please HMU. 🙌🏻
Heyy, since it's been more than I month. I just wanted to check upon this PR. Is there anything to be done from my end? Or what is the plan that we are looking at ahead?
This PR is being marked as stale due to a long period of inactivity
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@harjyotbagga - my apologies, it's been a crazy summer here and I haven't had alot of time to dedicate into cobra.
We'll get this in soon - this is a great feature add and thank you for your patience!
Thank you so much for the reply! Super happy to contribute. Please let me know if there are any changes to be done from my end!
This PR is being marked as stale due to a long period of inactivity
This PR is being marked as stale due to a long period of inactivity
This PR is being marked as stale due to a long period of inactivity
This PR is being marked as stale due to a long period of inactivity
This PR is being marked as stale due to a long period of inactivity