afero icon indicating copy to clipboard operation
afero copied to clipboard

Published 20 hours ago • verified publisher icon spf13

rename mem fs with descendants

Open hanagantig opened this issue 2 years ago • 1 comments

fix for issue #141 Please check it. This bug needs to be fixed.

hanagantig avatar Jun 25 '22 11:06 hanagantig

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 25 '22 11:06 CLAassistant

@bep hi, this is an old pull request for https://github.com/spf13/afero/issues/141 issue. I updated the branch and resolved conflicts. If you have time could you look at it please, it would be appreciated.

hanagantig avatar May 06 '23 10:05 hanagantig

@bep any comments or suggestions here please

hanagantig avatar Sep 07 '23 05:09 hanagantig

@hanagantig sorry for the delay; this looks correct, but it needs to be rebased with master. If you do that and ping me again, I will merge.

bep avatar Sep 07 '23 17:09 bep

@bep Thanks a lot. I just pushed it without merge commits. Could you please have a look?

hanagantig avatar Sep 07 '23 18:09 hanagantig

@hanagantig there's a staticcheck error there that should be easy to fix.

bep avatar Sep 08 '23 14:09 bep

@bep unnecessary assignment static check error fixed

hanagantig avatar Sep 08 '23 14:09 hanagantig

@bep can we merge it please ?

hanagantig avatar Sep 11 '23 14:09 hanagantig

@bep your attention is required. Could you please proceed with checks ?

hanagantig avatar Sep 22 '23 10:09 hanagantig

@bep thank you so much :pray:

hanagantig avatar Sep 23 '23 19:09 hanagantig