quick-encounters icon indicating copy to clipboard operation
quick-encounters copied to clipboard

V11 Error

Open uniwars opened this issue 1 year ago • 6 comments

Hi, with v11 and last module update I get this error in the module setup page :

The module "quick-encounters" is using "name" which is deprecated in favor of "id"

uniwars avatar Jul 11 '23 12:07 uniwars

Thanks for the report. Is this preventing installation or just a deprecation warning?

On Tue, Jul 11, 2023, 5:35 AM uniwars @.***> wrote:

Hi, with v11 and last module update I get this error in the module setup page :

The module "quick-encounters" is using "name" which is deprecated in favor of "id"

— Reply to this email directly, view it on GitHub https://github.com/spetzel2020/quick-encounters/issues/136, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSZYWUWVMMWKUPWJXXSIBLXPVB7PANCNFSM6AAAAAA2F6CPIE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

spetzel2020 avatar Jul 11 '23 13:07 spetzel2020

It is definitely true that Quick Encounters is still using the name field and I believe at some point I did see the deprecation warning that you mention.

However I have just done both an upgrade (from 1.1.5 to 1.1.6) and then an uninstall and reinstall, and in neither case do I see the message described. Can you help by saying whether it's an Error, Warning or otherwise?

spetzel2020 avatar Jul 11 '23 23:07 spetzel2020

sorry for the delay, it's a warning in the add-on module setup page, sorry for the confusion

uniwars avatar Jul 11 '23 23:07 uniwars

sorry for the delay, it's a warning in the add-on module setup page, sorry for the confusion

  • No problem. Is it preventing installation? (hopefully not if it's a warning).
  • What version of Foundry are you running?
  • If possible it would be great if you could uninstall/reinstall QE and send me a screenshot. I have been unable to reproduce and am not getting any direction from asking in the dev channel.

spetzel2020 avatar Jul 11 '23 23:07 spetzel2020

it doesn't prevent installation image V11 last stable 305

uniwars avatar Jul 12 '23 09:07 uniwars

Moving this to Milestone 1.3 for fixing deprecation warnings in v11. Hopefully can add id as an additional tag so that it will work in v9-v11.

spetzel2020 avatar Sep 13 '23 02:09 spetzel2020

Plan to add id as additional tag with Foundry v10-v12 support

spetzel2020 avatar Jun 17 '24 15:06 spetzel2020

Added in 12.1.0c (not yet released)

spetzel2020 avatar Jun 18 '24 00:06 spetzel2020

Released in 12.0.1; waiting on admin tool update.

spetzel2020 avatar Jun 19 '24 02:06 spetzel2020

Released in 12.1.1

spetzel2020 avatar Jun 21 '24 17:06 spetzel2020