electrum icon indicating copy to clipboard operation
electrum copied to clipboard

Known regressions since network-rewrite

Open SomberNight opened this issue 7 years ago • 5 comments

A very large chunk of the networking code was rewritten recently, using asyncio and aiorpcx. This introduced some regressions:

  • [x] merchant websockets are broken
    • being addressed in https://github.com/spesmilo/electrum/pull/4753
  • [x] the notify CLI command is broken
    • being addressed in https://github.com/spesmilo/electrum/pull/4753
  • some things are not using the proxy now (everything needs to use the proxy explicitly, unlike before where the socket module was monkey-patched)
    • [x] paying bip70 payment requests
    • [x] cosigner pool plugin
    • [x] digital bitbox 2fa
    • [x] greenaddress plugin
    • [x] email plugin
    • [ ] dnssec (for openalias)
  • [x] example scripts in the scripts directory

SomberNight avatar Oct 03 '18 15:10 SomberNight

bip70 now uses proxy with https://github.com/spesmilo/electrum/commit/1686a97ece31aaa1d2c0e6c7042137a5e8a04943

SomberNight avatar Nov 05 '18 18:11 SomberNight

dbb done https://github.com/spesmilo/electrum/commit/e1f4865844ce1bbdbd91a76b8ba245ae04b6300e

SomberNight avatar Dec 07 '18 18:12 SomberNight

greenaddress done 75f6ab913316998e1e3c4b1d256de17bc367ea8e

ecdsa avatar Dec 14 '18 07:12 ecdsa

email plugin was removed https://github.com/spesmilo/electrum/commit/c67c4e95dca6e0d5d995d8a11fea666918bcaab9

SomberNight avatar Aug 10 '22 22:08 SomberNight

cosigner pool plugin was fixed in https://github.com/spesmilo/electrum/commit/134fe73f1aa1da4afccd3361e5d3ea51e31a4bc4

SomberNight avatar Apr 17 '24 14:04 SomberNight