Santiago Pericas-Geertsen

Results 259 comments of Santiago Pericas-Geertsen

> The changes look fine to me, although I do have one question. > > I see the writer of the issue cited the SSE spec saying that "empty" events...

@nairiti-sharma Let's consider a buffer size of 2-4K as a potential new default. Apps can always increase this if necessary.

For a concrete use case, see discussion about CDI context propagation at the bottom of issue #3774

@mkarg Could you link the PR that deprecated the `valueOf` method? I can't recall how we got there.

Closing a connection is an event like many others. Would it make sense to consider the addition of a more generic _event listener_ instead?

@NicoNes Not necessary, my point is that _if_ we identify other useful events to listen for, these should all be grouped in a proper listener instead of creating a method...

Seems like a useful addition, as is the suggestion to support lookup for methods as well I think.

> Get well Markus, no rush. Also, it seems like now would be a good time to create a [release plan](https://projects.eclipse.org/projects/ee4j.rest) for 4.1 (or 5.0 if needed) and add this...

What is the real benefit in natively supporting `java.nio.file.Path` when you have `java.nio.file.Path#toFile`? Just trying to understand the rationale here.