Spencer Finnell

Results 38 comments of Spencer Finnell

I know it's a very risky thing to update but I believe the fixes in https://github.com/easydigitaldownloads/easy-digital-downloads/commit/c57a3fad0d1c8ba2e0b223af5272343d58ce4ba6 will help. - When outputting the value of fields registered with the settings API...

I didn’t see any settings registering that when I checked but I’ll look at Rich editors again.

The standard (default) value is set as an empty string though which allows it to be blank I think? I’ll test with the extensions and see what I find.

What's confusing to me is `allow_blank` is only affecting the output of these settings once they have already been saved as blank. So a blank setting is still being saved...

https://github.com/easydigitaldownloads/easy-digital-downloads/commit/ee383d30607ee74a1da8f7ef25f73b2a7a51adb3 Makes sure a blank input is never stored if the setting does not allow it.

👍 Attached a PR for easier testing. Definitely realize it's a daunting one to introduce and since I think these problems have existed for a little while now there's no...

@SDavisMedia Basically each field type needs to be saved/updated/edited and ensure the expected behavior is in both places: 1. The database. 2. The output of the value in the field....

@aristath https://github.com/easydigitaldownloads/easy-digital-downloads/blob/release/3.0/assets/js/edd-ajax.js is the development-mode built version of https://github.com/easydigitaldownloads/easy-digital-downloads/blob/release/3.0/assets/js/frontend/edd-ajax.js -- when it is built for release via `npm run build` it will be much smaller. Run `npm install && npm...

@aristath We need to [support IE 11](https://make.wordpress.org/core/handbook/best-practices/browser-support/), and using `forEach` on a `NodeList` [isn't supported](https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach#Browser_Compatibility). The admin scripts set `underscore` as a dependency and use `_.each`, but for the frontend...

I am unsure of the current plans but I will add a link to a recent article with some more details about performance impact of jQuery: https://make.wordpress.org/themes/2021/10/04/the-performance-impact-of-using-jquery-in-wordpress-themes/