spectre-meltdown-checker icon indicating copy to clipboard operation
spectre-meltdown-checker copied to clipboard

Issue 429: analyse/lint and format script

Open thomasmerz opened this issue 2 years ago • 4 comments

This PR fixes #429 by these changes:

  👷 add a fancy GitHub action for 'shellcheck' and 'shfmt'
  👷 moved 'shellcheck' and 'check indentation' to new GitHub Action
  🚨 fix 'shellcheck' warnings
  🚨 fix 'shfmt' warnings

Contrary to my expectations I had to fix some warnings in spectre-meltdown-checker.sh which finalize in some minor changes. 🤷🏻‍♂️


Please have a look at my latest GitHub Action run in my forked repo:

image image image

thomasmerz avatar Mar 30 '22 13:03 thomasmerz

BTW: I use https://github.com/itspriddle/vim-shellcheck and https://github.com/z0mbix/vim-shfmt for local checking while writing/fixing code and https://github.com/nektos/act for a final local check running in a local GitHub Action in docker containers on my linux machine (which makes some trouble with the docker-in-docker steps on my linux machine 🤷🏻‍♂️ ).

thomasmerz avatar Mar 30 '22 14:03 thomasmerz

I also added some example GitHub Actions for a bad linting/shell syntax and a good (fixed) one.

thomasmerz avatar Mar 30 '22 14:03 thomasmerz

Hey @speed47 , can you please review this PR? Thank you.

thomasmerz avatar May 29 '22 10:05 thomasmerz