spectre-meltdown-checker
spectre-meltdown-checker copied to clipboard
Issue 429: analyse/lint and format script
This PR fixes #429 by these changes:
👷 add a fancy GitHub action for 'shellcheck' and 'shfmt'
👷 moved 'shellcheck' and 'check indentation' to new GitHub Action
🚨 fix 'shellcheck' warnings
🚨 fix 'shfmt' warnings
Contrary to my expectations I had to fix some warnings in spectre-meltdown-checker.sh
which finalize in some minor changes. 🤷🏻♂️
Please have a look at my latest GitHub Action run in my forked repo:



BTW: I use https://github.com/itspriddle/vim-shellcheck and https://github.com/z0mbix/vim-shfmt for local checking while writing/fixing code and https://github.com/nektos/act for a final local check running in a local GitHub Action in docker containers on my linux machine (which makes some trouble with the docker-in-docker steps on my linux machine 🤷🏻♂️ ).
Hey @speed47 , can you please review this PR? Thank you.