snitch icon indicating copy to clipboard operation
snitch copied to clipboard

Support for PrivateAssets property containing keyword compile

Open sorensenmatias opened this issue 2 years ago • 2 comments

Fixes a bug where snitch reports PackageReferences that can be removed, even though the referenced project has specified the PackageReference with PrivateAssets containg the keyword "compile". This means that removing the PackageReference will actually break the build. See here for more information: https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#controlling-dependency-assets

sorensenmatias avatar Jul 28 '22 19:07 sorensenmatias

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 28 '22 19:07 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Matias Sørensen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 28 '22 19:07 CLAassistant

@sorensenmatias You will need to sign the CLA agreement as well.

patriksvensson avatar Aug 24 '22 07:08 patriksvensson

@sorensenmatias You will need to sign the CLA agreement as well.

@patriksvensson Oops - it's done. Thanks.

sorensenmatias avatar Aug 24 '22 07:08 sorensenmatias

Merged! Thank you for your contribution. Much appreciated! 👍

patriksvensson avatar Aug 24 '22 08:08 patriksvensson