spectre.console
spectre.console copied to clipboard
Preserve links when markup is being truncated/linebroken
fixes #363
- [x] I have read the Contribution Guidelines
- [ ] I have commented on the issue above and discussed the intended changes
- [ ] A maintainer has signed off on the changes and the issue was assigned to me
- [ ] All newly added code is adequately covered by tests
- [ ] All existing tests are still running without errors
- [ ] The documentation was modified to reflect the changes OR no documentation changes are required.
Changes
This doesn't fix the ID issues talked about in the original issue, only the link target being incorrect when the segment is split over multiple lines or truncated and the link is to be generated via the text e.g. [link]https://example.com[/].
Attempting to share a link ID over these portions makes things much more complex and the end result is just that the link will have a correct hover effect on some terminals. This could be addressed in a separate change.
Please upvote :+1: this pull request if you are interested in it.