spectre.console icon indicating copy to clipboard operation
spectre.console copied to clipboard

Selection Prompt Search

Open slang25 opened this issue 2 years ago • 4 comments

Multi Selection Search

This PR adds a couple of features to Selection Prompt:

  • Search as you type
  • Skipping selection of group nodes for Leaf selection mode

I've yet to add the tests which is a bit naughty, but wanted to share what I have so far to start some discussion. Is this feature welcome, or is there a better direction?

slang25 avatar Sep 03 '23 18:09 slang25

This is somewhat related to #1258, as this is a feature I'd really like in my CLI, however my only feasible options are to fork the library or hope I can get this merged.

slang25 avatar Sep 03 '23 18:09 slang25

This looks incredibly helpful - I'd love to see this merged soon.

GOATS2K avatar Sep 14 '23 20:09 GOATS2K

Thanks @GOATS2K, I'm pretty happy with it and am using it in one of my apps. I've just updated the API names to be a bit more sensible.

@patriksvensson what are your thoughts on this?

slang25 avatar Sep 15 '23 13:09 slang25

@patriksvensson thanks for taking a look, I've addressed the feedback. I've added some tests, I could add some Verify tests too and cover more scenarios but am on the fence, let me know what you think.

slang25 avatar Sep 24 '23 09:09 slang25

Hi @patriksvensson, please could you take another look at this PR when you get some time. I'm happy to address any further feedback 🙂

slang25 avatar Feb 23 '24 14:02 slang25

Would love to see this go through soon, extremely useful feature when dealing with large prompts.

Jacob-32587 avatar Feb 25 '24 05:02 Jacob-32587

@slang25 I'm rebasing this and fixing the merge conflicts right now

patriksvensson avatar Feb 25 '24 11:02 patriksvensson

Merged! Thank you for your contribution. Much appreciated! 👍

patriksvensson avatar Feb 25 '24 11:02 patriksvensson

Thanks @patriksvensson, this library is such a gem for the .NET community, I hope you have time to keep it going 🙂 I was worried we'd lose you to swift 😅

slang25 avatar Feb 25 '24 13:02 slang25

@slang25 Haha, thanks! I still have a lot of love for dotnet 🙂

patriksvensson avatar Feb 25 '24 14:02 patriksvensson