Kyle Lippincott
Kyle Lippincott
I'm not generally a huge fan of "argument that changes the behavior of the following arguments", unless I can convince myself that it's a mode selector for the entire command....
So based on that clap documentation, if I wrote `jj log -p foo bar --no-pager baz`, where `--no-pager` doesn't take an argument, this would interpret `baz` as a revision (after...
> @spectral54: Didn't you also work on this recently? It probably makes sense for you to review this PR and compare it to your draft in that case. Indeed. I...
Pros of adding to `cmd_help()`: 1. `jj --config aliases.np=["--no-pager"] help np` could work, I think that might be difficult to support otherwise? Cons of only adding to `cmd_help()`: 1. running...
> Tab completion wouldn't work either for `jj help `. I meant tab completion of aliases: `jj my_alia` isn't given "for free" if all we do is modify `cmd_help()`, we'd...
Confirmed on Discord that this is a known limitation. Current workaround I'm using, mostly thanks to AxCut on Discord: ``` namespace impl { struct DelimStringElement { DataType element; if (element...
I just encountered this with `jj` (http://github.com/martinvonz/jj). I was also able to reproduce with `git blame` on a file that had significant history, but fewer lines than $LINES (I wasn't...
Is there anything we can do to work around this issue, such as an environment variable that `git`, `hg`, `jj`, and any others can set that disables the new behavior,...
Thank you! The concern I have with this being a CLI option, however, is that we need to either version-detect `less` to know it has it, or we can only...
I believe every case we've encountered at $dayjob where this has come up has had `PAGER=less` (or equivalent like /usr/bin/less). Gut feeling is that 1-3% (let's call it 2%) of...