speckle-sharp icon indicating copy to clipboard operation
speckle-sharp copied to clipboard

bug(revit): receiving parameter updater for an non-editable element does not log ui error

Open dtnaughton opened this issue 2 years ago • 0 comments

Prerequisites

What package are you referring to?

speckle-sharp

Describe the bug

We had a condition where a user was trying to receive an ParameterUpdater object into a model where the element was in a non-editable workset. The parameter was unable to update because of this (which triggered the error eater), but this doesn't get represented on the UI report as the application object state doesn't get updated after conversion from ParameterUpdater objs. It would be an improved user experience if these errors surface in the UI report.

Has there been consideration of checking if elements on non-editable worksets in general? I know the Revit API WorksharingUtils class has some methods exposed to check if elements are editable or not. Are these factored into conversion etc?

To Reproduce

  1. Set up model with elements on non-editable workset
  2. Receive a ParameterUpdater obj targeting an element on one of these worksets

Expected behavior

UI report should communicate error with user.

Screenshots

image

System Info

If applicable, please fill in the below details - they help a lot!

Desktop (please complete the following information):

windows

dtnaughton avatar Jun 30 '23 13:06 dtnaughton