speckle-sharp icon indicating copy to clipboard operation
speckle-sharp copied to clipboard

Published 20 hours ago • verified publisher icon specklesystems

Core: Implement New Invite Strategy

Open AlanRynne opened this issue 3 years ago • 1 comments

2 Core tests are failing due to a miss-alignment with speckle-server: https://app.circleci.com/pipelines/github/specklesystems/speckle-sharp/6736/workflows/73f23ab4-72df-46ff-9767-5e084f965972/jobs/19064

Change was introduced here https://github.com/specklesystems/speckle-server/commit/da9224a069cace19087952fcfa610c84726eb854

AlanRynne avatar Jul 21 '22 15:07 AlanRynne

Updated the issue title as there are a few more things that should be done here:

  • [ ] update the existing StreamInviteCreate method in core to invite users by Id as well and not just email
  • [ ] update DUI correspondingly to say Invite instead of Add etc
  • [ ] create StreamInviteCreate tests (if possible?)
  • [ ] update StreamUpdatePermission tests (if possible?)
  • [ ] optional: show pending invites in DUI

teocomi avatar Jul 22 '22 09:07 teocomi

I'm assuming this was left open by mistake, as all linked PRs are merged already, so I'm closing it

AlanRynne avatar Sep 01 '22 10:09 AlanRynne