speckle-sharp icon indicating copy to clipboard operation
speckle-sharp copied to clipboard

feat(objects): views & cameras

Open izzylys opened this issue 3 years ago • 1 comments

Description

  • adds new View and Camera classes to Objects.Other
  • tests out c#8 nullable props

addresses #1088

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

(( still wip))

  • Tests not required
  • Unit/Integration Tests (which?)
  • Manual Tests (please write what did you do?)

Docs

  • Will be updated ASAP

izzylys avatar Mar 08 '22 18:03 izzylys

Codecov Report

Merging #1087 (53faaec) into main (565b6a6) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1087   +/-   ##
=======================================
  Coverage   45.09%   45.09%           
=======================================
  Files          58       58           
  Lines        4542     4542           
  Branches      707      707           
=======================================
  Hits         2048     2048           
  Misses       2324     2324           
  Partials      170      170           
Impacted Files Coverage Δ
Core/Core/Kits/Units.cs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 565b6a6...53faaec. Read the comment docs.

codecov[bot] avatar Mar 08 '22 18:03 codecov[bot]

Closing this because stale. The issue remains open and the PR is referenced so we can re-open it whenever we tackle this.

AlanRynne avatar Sep 30 '22 16:09 AlanRynne