speckle-server icon indicating copy to clipboard operation
speckle-server copied to clipboard

WIP: Local deploy kind and skaffold

Open iainsproat opened this issue 3 years ago • 4 comments

⚠️ - currently broken and WIP. This PR is an attempt to use skaffold to deploy dev builds locally to either kind or minikube ( profiles to be added :) ). It also deploys a kind cluster locally.

iainsproat avatar Aug 08 '22 08:08 iainsproat

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
2532158 Generic High Entropy Secret a0f82aeb6769b8eae875dca85cc2c59a21caae25 packages/frontend/src/bootstrapper.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Aug 08 '22 08:08 gitguardian[bot]

Codecov Report

Merging #900 (8670d51) into main (44bd591) will increase coverage by 0.37%. The diff coverage is n/a.

:exclamation: Current head 8670d51 differs from pull request most recent head b3eb310. Consider uploading reports for the commit b3eb310 to get more accurate results

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   90.17%   90.54%   +0.37%     
==========================================
  Files          90       87       -3     
  Lines        3449     3374      -75     
  Branches       41        5      -36     
==========================================
- Hits         3110     3055      -55     
+ Misses        330      319      -11     
+ Partials        9        0       -9     
Impacted Files Coverage Δ
...es/serverinvites/services/inviteCreationService.js 90.19% <0.00%> (-0.37%) :arrow_down:
...server/modules/serverinvites/repositories/index.js 96.20% <0.00%> (-0.05%) :arrow_down:
packages/server/modules/shared/index.js 97.01% <0.00%> (ø)
...rver/modules/emails/services/templateFormatting.ts
packages/server/modules/core/dbSchema.ts
packages/server/modules/shared/errors/base.ts
packages/server/modules/shared/authz.ts
packages/server/modules/shared/errors/index.ts
...kages/server/modules/core/helpers/mainConstants.ts
...ackages/server/modules/emails/utils/transporter.js
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 08 '22 08:08 codecov[bot]

What does this add, that the current minikube based local installation doesn't provide (besides not using make to do stuff)?

gjedlicska avatar Aug 08 '22 09:08 gjedlicska

@gjedlicska - this PR was mostly me experimenting for now in my spare time, you can ignore it for the meantime!

If it was to be merged, I'd split it into two PRs first - one for skaffold and one for kind.

  • in theory kind should have a faster startup time over minikube (will have to experiment to verify this in the context of our CI), which would bring down our CI times (especially for PRs, where server-test is the longest running job).

  • skaffold would replace the Makefile. It deals with ensuring the deployed helm chart matches up with the correct docker image (a very slight improvement over using a mutable local tag). It runs the builds in parallel, which should speed things up further. It may make port-forwarding easier, and it also provides a filewatcher which would update the deployed helm chart & images while working on code.

iainsproat avatar Aug 08 '22 09:08 iainsproat

Obsolete

iainsproat avatar Jan 18 '23 09:01 iainsproat