speckle-server
speckle-server copied to clipboard
Blobs API SDK Driven Changes
tl;dr:
- [server] we're now accepting client file hashes that we use as blob ids
- [server] adds a new endpoint for diffing blobs based on said hashes (allows clients to not send existing blobs)
- [server] guards with a
on conflict do nothingblob entry creation - [objectloader] filters out blob ids from object's
__closure
Codecov Report
Base: 89.43% // Head: 89.27% // Decreases project coverage by -0.16% :warning:
Coverage data is based on head (
051929b) compared to base (636d4b0). Patch coverage: 40.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #845 +/- ##
==========================================
- Coverage 89.43% 89.27% -0.17%
==========================================
Files 144 144
Lines 4752 4763 +11
Branches 264 264
==========================================
+ Hits 4250 4252 +2
- Misses 396 405 +9
Partials 106 106
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/server/modules/blobstorage/index.js | 81.81% <36.36%> (-6.65%) |
:arrow_down: |
| packages/server/modules/blobstorage/services.js | 95.40% <50.00%> (-2.28%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Leftover todos:
- [x] resolve conflicts
- [x] review with @gjedlicska
- [x] merge 🤞
⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 2532158 | Generic High Entropy Secret | 051929b23c69c3b8d4c685da90ee7b73513254f0 | packages/frontend/src/bootstrapper.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!