speckle-server icon indicating copy to clipboard operation
speckle-server copied to clipboard

Published 20 hours ago • verified publisher icon specklesystems

chore(fe2): update graphql serverinfo to use new configuration object

Open iainsproat opened this issue 1 year ago • 2 comments

Description & motivation

The graphql API exposes a new ServerInfo{ configuration } object which now includes blobSizeLimitBytes.

The graphql API has deprecated ServerInfo{ blobSizeLimitBytes }.

This updates frontend-2 to use the new API.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • [ ] My pull request follows the guidelines in the Contributing guide?
  • [ ] My pull request does not duplicate any other open Pull Requests for the same update/change?
  • [ ] My commits are related to the pull request and do not amend unrelated code or documentation.
  • [ ] My code follows a similar style to existing code.
  • [ ] I have added appropriate tests.
  • [ ] I have updated or added relevant documentation.

References

iainsproat avatar Aug 23 '24 11:08 iainsproat

WEB-1665 Server should provide graphql API endpoint for querying max object size etc..

linear[bot] avatar Aug 23 '24 11:08 linear[bot]

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Aug 23 '24 11:08 gitguardian[bot]

looks OK, but I think you've missed a few places that need changing, at least according to the linter

fabis94 avatar Oct 09 '24 12:10 fabis94

looks OK, but I think you've missed a few places that need changing, at least according to the linter

I found some more places to update, and pushed those so it's ready to review again. (I also ran a yarn gqlgen, so there's some additional changes that it caught).

@fabis94 - If your linter is still showing some remaining uses that I've missed, could you paste the linter output please?

iainsproat avatar Oct 15 '24 09:10 iainsproat