connexion icon indicating copy to clipboard operation
connexion copied to clipboard

Extract boilerplate code into Routed base classes

Open RobbeSneyders opened this issue 2 years ago • 1 comments

As mentioned in #1588, we're repeating a lot of boilerplate across the middlewares. This PR extracts this boilerplate into shared base classes. Feel free to propose better naming for them :slightly_smiling_face:

I had to revert the order of Middleware - Api - Operation to Operation - Api - Middleware due to dependencies in the typing.

RobbeSneyders avatar Sep 16 '22 20:09 RobbeSneyders

Pull Request Test Coverage Report for Build 3130067976

  • 144 of 154 (93.51%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 95.243%

Changes Missing Coverage Covered Lines Changed/Added Lines %
connexion/middleware/routing.py 25 27 92.59%
connexion/middleware/abstract.py 64 72 88.89%
<!-- Total: 144 154
Totals Coverage Status
Change from base Build 3129982881: 0.03%
Covered Lines: 2843
Relevant Lines: 2985

💛 - Coveralls

coveralls avatar Sep 18 '22 09:09 coveralls