dartz icon indicating copy to clipboard operation
dartz copied to clipboard

Comment indicates side effect in method where none exists

Open zellidev0 opened this issue 2 years ago • 0 comments

In the option.dart file a comment suggests that the code below the comment has side effects.

// PURISTS BEWARE: side effecty stuff below -- proceed with caution!

One Method there is the toNullable() method.

It looks like that:

A? toNullable() => fold(() => null, id);

This method does not seem to create a side effect and therefore it should be above the stated comment to avoid confusion.

I would create a PR that moves the method upwords, so that it is above the comment. Would this PR be merged?

zellidev0 avatar Oct 07 '22 09:10 zellidev0