tools-python
tools-python copied to clipboard
Fix up a few filesAnalyzed issues
Looks like circleci stuff on mac is broken. I'm not quite sure how to fix it.
And sorry if I did update your branch by mistake with the latest. Let's pretend it was because of fat fingers.
Yes, of course. I'll add some tests.
@lhh Thank you! you rock.
I am chasing possibly a bug in the RDF writer not handling multiple packages properly (particularly when one is filesAnalyzed = false), which is why that and the tag/value writer tests are not present yet. My apologies for the delay.
I'm out for a few days.
Should package_object["packageVerificationCode"] = self.package_verification_code(
be optional or 'mandatory missing' per spec version 2.2 https://spdx.github.io/spdx-spec/package-information/#79-package-verification-code-field
Should
package_object["packageVerificationCode"] = self.package_verification_code(
be optional or 'mandatory missing' per spec version 2.2 https://spdx.github.io/spdx-spec/package-information/#79-package-verification-code-field
@dholth this code is a source of troubles more often than not. We should make it optional in this library IMHO.
@lhh, do you still plan on updating this PR?
Ah, yes - my apologies. I'll address the above issues shortly.
@pombredanne you still have a blocker on this PR. As I don't want to dismiss your review, would you care to have a short look at it again?