tools-python icon indicating copy to clipboard operation
tools-python copied to clipboard

Fix up a few filesAnalyzed issues

Open lhh opened this issue 3 years ago • 10 comments

lhh avatar Oct 19 '21 20:10 lhh

Looks like circleci stuff on mac is broken. I'm not quite sure how to fix it.

lhh avatar Oct 19 '21 20:10 lhh

And sorry if I did update your branch by mistake with the latest. Let's pretend it was because of fat fingers.

pombredanne avatar Oct 19 '21 20:10 pombredanne

Yes, of course. I'll add some tests.

lhh avatar Oct 20 '21 11:10 lhh

@lhh Thank you! you rock.

pombredanne avatar Oct 20 '21 12:10 pombredanne

I am chasing possibly a bug in the RDF writer not handling multiple packages properly (particularly when one is filesAnalyzed = false), which is why that and the tag/value writer tests are not present yet. My apologies for the delay.

I'm out for a few days.

lhh avatar Oct 21 '21 18:10 lhh

Should package_object["packageVerificationCode"] = self.package_verification_code( be optional or 'mandatory missing' per spec version 2.2 https://spdx.github.io/spdx-spec/package-information/#79-package-verification-code-field

dholth avatar Nov 22 '21 19:11 dholth

Should package_object["packageVerificationCode"] = self.package_verification_code( be optional or 'mandatory missing' per spec version 2.2 https://spdx.github.io/spdx-spec/package-information/#79-package-verification-code-field

@dholth this code is a source of troubles more often than not. We should make it optional in this library IMHO.

pombredanne avatar Dec 15 '21 14:12 pombredanne

@lhh, do you still plan on updating this PR?

armintaenzertng avatar Oct 20 '22 11:10 armintaenzertng

Ah, yes - my apologies. I'll address the above issues shortly.

lhh avatar Oct 20 '22 12:10 lhh

@pombredanne you still have a blocker on this PR. As I don't want to dismiss your review, would you care to have a short look at it again?

armintaenzertng avatar Oct 21 '22 09:10 armintaenzertng