tools-python icon indicating copy to clipboard operation
tools-python copied to clipboard

[WIP][Do not merge] Add relationships to python-tools

Open ShubhamKJha opened this issue 4 years ago • 6 comments

Signed-off-by: Shubham Kumar Jha [email protected]

Fixes #138

ShubhamKJha avatar Jun 14 '20 04:06 ShubhamKJha

The errors doesn't look due to the changes I've made, instead it appears some dependencies are not supported in some Python versions.

ShubhamKJha avatar Jun 14 '20 10:06 ShubhamKJha

@ShubhamKJha I think you first need to create tests for the new file relationship that you have created, try checking on your local system by creating test. after that, you have to change the parsers code and make it compatible with all the formats. after that, adding the class to the examples and modifying the data will complete this issue.

Yash-Varshney avatar Jun 16 '20 03:06 Yash-Varshney

Also, @goneall @pombredanne can guide if I am right?

Yash-Varshney avatar Jun 16 '20 03:06 Yash-Varshney

@pombredanne If you could verify the approach - I'm not as familiar with the Python tag/value parser

goneall avatar Jun 16 '20 05:06 goneall

@goneall it is currently in a very basic state, I would ask for a review once I'm ready. I just felt that the test-fails were not related to my changes here and hence I ran tests on the master of my fork. The tests are still failing. I'm looking into it, will give a better analysis when I find something.

ShubhamKJha avatar Jun 16 '20 16:06 ShubhamKJha

As #138 is closed and no progress has been made here for over two years, I suggest to close this PR.

@ShubhamKJha, any objections?

armintaenzertng avatar Oct 20 '22 10:10 armintaenzertng

Closing this for now as relationships were added already. Please ping me or someone else if it should be reopened

nicoweidner avatar Oct 31 '22 17:10 nicoweidner