spdx-spec icon indicating copy to clipboard operation
spdx-spec copied to clipboard

ID inside annotations

Open Yash-Varshney opened this issue 5 years ago • 2 comments

This issue's inspiration is - here ( 7th point)

In the previous version of SPDX (which presently python tool supports), there is ID inside annotations whereas in v2.2 ID is missing.

  • Annotations in previous versions
"annotations": [
            {
                "comment": "This is just an example. Some of the non-standard licenses look like they are actually BSD 3 clause licenses", 
                "annotationType": "REVIEW", 
                "id": "SPDXRef-45", 
                "annotationDate": "2012-06-13T00:00:00Z", 
                "annotator": "Person: Jim Reviewer"
            }
        ], 
  • Annotations in latest version
"annotations" : [ {
    "annotationDate" : "2010-01-29T18:30:22Z",
    "annotationType" : "OTHER",
    "annotator" : "Person: Jane Doe ()",
    "comment" : "Document level annotation"
  }, 

It might cause problem in providing stability and support to previous versions' parsing.

Yash-Varshney avatar Oct 01 '20 19:10 Yash-Varshney

@goneall - I think we need to transfer this one to the python tools to check?

kestewart avatar Aug 10 '22 02:08 kestewart

@kestewart In thinking about this, it will change back to an ID in spec version 3.0 since annotations are full elements.

I'm going to move this to the 3.0 milestone.

goneall avatar Aug 10 '22 16:08 goneall

This is resolved in 3.0 - closing

goneall avatar Apr 04 '24 16:04 goneall