spdx-spec icon indicating copy to clipboard operation
spdx-spec copied to clipboard

Add spdx3-validate to examples validation workflow

Open bact opened this issue 1 year ago • 1 comments

  • Add spdx3-validate to bin/check-examples.sh script
  • spdx3-validate can handle spdxId references with ExternalMap
  • It is currently used in https://github.com/spdx/spdx-examples/blob/master/.github/workflows/pull_request.yml
  • This PR also modified bin/check-examples.sh to print relevant environment variables to assist debugging

bact avatar Oct 08 '24 04:10 bact

Validation failed due to individual-related issue. Turn to draft for now.

bact avatar Oct 08 '24 04:10 bact

The validation script can run and print results as expected. (But the validation result of the file being tested is failed)

bact avatar Nov 19 '24 01:11 bact

It looks like the validation is failing - it also failed on a previous PR - so likely not do to these changes.

@bact - if you find the source of the failure, can you include a fix in this PR?

goneall avatar Nov 19 '24 04:11 goneall

@goneall the validation fail is from the known issue of missing CreationInfo for individuals.

We need to add it when generating the ontology file, with this PR https://github.com/spdx/spec-parser/pull/154 or similar.

bact avatar Nov 19 '24 06:11 bact

@goneall @zvr @ilans the CreationInfo issue is probably fixed now. But because of the assessedElement range update, the example failed. I will update the example and check again.

bact avatar Dec 05 '24 19:12 bact

@goneall @zvr @ilans The old 5 violations about missing CreationInfo are fixed. But we have new violations about new 5 cretionInfo_*.

I opened a separated issue for that at https://github.com/spdx/spdx-3-model/issues/936

bact avatar Dec 06 '24 05:12 bact

Example validation is passed now.

bact avatar Dec 10 '24 20:12 bact

@goneall please review this. All validations are passed now.

bact avatar Jan 10 '25 03:01 bact

  • See also https://github.com/spdx/spdx-3-model/issues/956 for the need of spdx3-validate

bact avatar Jan 16 '25 10:01 bact

Since it has been more than 10 days with 1 review, I'll go ahead and merge this PR

goneall avatar Jan 21 '25 19:01 goneall