spdx-spec icon indicating copy to clipboard operation
spdx-spec copied to clipboard

Setup RDF redirections in spdx.org (to fix failed validation)

Open bact opened this issue 1 year ago • 11 comments

For 3.0.1:

  1. a: https://spdx.org/rdf/3.0.1/spdx-model.ttl -> b: https://spdx.github.io/spdx-spec/v3.0.1/rdf/spdx-model.ttl
  2. a: https://spdx.org/rdf/3.0.1/spdx-context.jsonld -> b: https://spdx.github.io/spdx-spec/v3.0.1/rdf/spdx-context.jsonld
  3. a: https://spdx.org/rdf/3.0.1/spdx-json-serialize-annotations.ttl -> b: https://spdx.github.io/spdx-spec/v3.0.1/rdf/jsonld-annotations.ttl
  4. a: https://spdx.org/schema/3.0.1/spdx-json-schema.json -> b: https://spdx.github.io/spdx-spec/v3.0.1/rdf/schema.json
  • 1a, 2a, 3a, 4a are not exist yet, need to setup.
  • 1b, 2b, 3b, 4b are readily accessible.
    • But content of 3b still has to be updated by PR #1096

--

For 3.0.0:

  1. a: https://spdx.org/rdf/3.0.0/spdx-model.ttl -> b: https://spdx.github.io/spdx-spec/v3.0.0/rdf/spdx-model.ttl
  2. a: https://spdx.org/rdf/3.0.0/spdx-context.jsonld -> b: https://spdx.github.io/spdx-spec/v3.0.0/rdf/spdx-context.jsonld
  3. https://spdx.org/rdf/3.0.0/spdx-json-serialize-annotations.ttl -> b: https://spdx.github.io/spdx-spec/v3.0.0/rdf/jsonld-annotations.ttl
  4. a: https://spdx.org/schema/3.0.0/spdx-json-schema.json -> b: https://spdx.github.io/spdx-spec/v3.0.0/rdf/schema.json
  • 5a, 6a, 7a, 8a are already exist but redirected to "v3.0" links; for example, at: https://spdx.github.io/spdx-spec/v3.0/model/spdx-context.jsonld - which its content is now the latest of v3.0 (now v3.0.1) - and this made some validations fail, as they may expected 3.0.0 but received 3.0.1
  • 5b, 6b, 7b, 8b are to be setup by PR #1109 (alternatively, and better way, we can republish the entire old v3.0 as v3.0.0; PR 1109 is more like a quick interim fix)

(URL lists based on https://github.com/spdx/spdx-3-model/issues/679#issuecomment-2032543594 )

bact avatar Sep 06 '24 12:09 bact

I wonder if I should go ahead and setup the 3.0.1 redirects now since they are live.

We should probably wait for the 3.0 redirects until final release.

@kestewart @bact @zvr - thoughts?

goneall avatar Sep 06 '24 17:09 goneall

Ideally, for 3.0.1 (Items 1-4) we should wait until the final release.

For 3.0.0 (Items 5-8), they are broken* now and need to be fixed by modifying redirections at spdx.org (5a-8a) together with PR #1109 (5b-8b).

*Broken here means the version in URL and the version in the content are not matched. This made, for example, our validator failed.

bact avatar Sep 06 '24 17:09 bact

Just saw a slack message on 3.0.0 being broken - so I'll go ahead and merge #1109 and setup the redirects. I'll leave the 3.0.1 and 3.0 redirects until after release.

goneall avatar Sep 06 '24 17:09 goneall

Redirects for 3.0.0 (Items 5-8) are in place and PR #1109 has been merged.

It may take some time for the changes to propagate we may need to clear our browser caches for it to take effect.

goneall avatar Sep 06 '24 18:09 goneall

Thank you. I will try and report.

bact avatar Sep 06 '24 18:09 bact

I'll leave the 3.0.1 and 3.0 redirects until after release.

Agree.

bact avatar Sep 06 '24 18:09 bact

Confirmed

https://spdx.org/rdf/3.0.0/spdx-context.jsonld is now redirected to https://spdx.github.io/spdx-spec/v3.0.0/rdf/spdx-model.ttl

Browser cached may needed.

bact avatar Sep 06 '24 22:09 bact

3.0.0 validation is good now.

3.0.1 validation is waiting for Items 1-4. (Validation CI will get updated by #1111)

bact avatar Sep 07 '24 00:09 bact

I wonder if I should go ahead and setup the 3.0.1 redirects now since they are live.

We should probably wait for the 3.0 redirects until final release.

@goneall I have changed my mind.

We may need 3.0.1 redirects now to pass the validation.

3.0 can be wait until after 3.0.1 actually release.

bact avatar Sep 07 '24 13:09 bact

I wonder if I should go ahead and setup the 3.0.1 redirects now since they are live. We should probably wait for the 3.0 redirects until final release.

@goneall I have changed my mind.

We may need 3.0.1 redirects now to pass the validation.

3.0 can be wait until after 3.0.1 actually release.

All the 3.0.1 redirects are now in place - we just have the 3.0 redirects which we can do after the release.

goneall avatar Sep 07 '24 18:09 goneall

Thank you Gary.

bact avatar Sep 07 '24 18:09 bact

Change redirects for 3.0 -> 3.0.1 version

goneall avatar Dec 17 '24 17:12 goneall

All the 3.0.1 redirects are now in place - we just have the 3.0 redirects which we can do after the release.

@goneall Do we still like to do the redirections for 3.0?

For example,

  • https://spdx.org/rdf/3.0/spdx-model.ttl -> (https://spdx.org/rdf/3.0.1/spdx-model.ttl ->) https://spdx.github.io/spdx-spec/v3.0.1/rdf/spdx-model.ttl

bact avatar Jan 15 '25 00:01 bact

All the 3.0.1 redirects are now in place - we just have the 3.0 redirects which we can do after the release.

@goneall Do we still like to do the redirections for 3.0?

For example,

  • https://spdx.org/rdf/3.0/spdx-model.ttl -> (https://spdx.org/rdf/3.0.1/spdx-model.ttl ->) https://spdx.github.io/spdx-spec/v3.0.1/rdf/spdx-model.ttl

I setup redirects for https://spdx.ord/rdf/3.0/[file] to https://spdx.github.io/spdx-spec/v3.0/rdf/[file] - which will in turn redirect to the latest patch version.

@bact @zvr - if this approach is OK, please feel free to close this issue

goneall avatar Jan 21 '25 19:01 goneall

I setup redirects for https://spdx.ord/rdf/3.0/[file] to https://spdx.github.io/spdx-spec/v3.0/rdf/[file] - which will in turn redirect to the latest patch version.

@bact @zvr - if this approach is OK, please feel free to close this issue

LGTM. Thank you

bact avatar Jan 21 '25 21:01 bact

I'll go ahead and close this as resolved

goneall avatar Jan 21 '25 22:01 goneall