spdx-online-tools icon indicating copy to clipboard operation
spdx-online-tools copied to clipboard

Add link of the GitHub Issue from the License Information page

Open BanulaKumarage opened this issue 1 year ago • 9 comments

Even though there is a link to access the request of the online tool from the Github issue, there is no link to access the GitHub issue from the online tool.

BanulaKumarage avatar Mar 29 '23 19:03 BanulaKumarage

Yes, I think this would be helpful to the user as currently, we are only opening a new tab for discussion for the github issues as per Redirect on Successful License Submission.

BassCoder2808 avatar Mar 30 '23 07:03 BassCoder2808

Actually, this issue can be closed as #452 intends to solve the same with some other minor changes.

BassCoder2808 avatar Apr 01 '23 09:04 BassCoder2808

Actually, this issue can be closed as #452 intends to solve the same with some other minor changes.

@BassCoder2808 I think it's good to solve this with #454 instead of solving it under #452

BanulaKumarage avatar Apr 01 '23 10:04 BanulaKumarage

add link to Github issue created from license submission to list of submitted licenses at https://tools.spdx.org/app/license_requests/

@BassCoder2808 - has this been solved for and merged?

jlovejoy avatar Jun 21 '23 19:06 jlovejoy

Hi @jlovejoy actually there has been some miscommunications like there are 2 issues and 2 PRs that solve the 2 issues separately which in the end intend to do the same task. So what I feel is that we can move forward with #452 (just because it was opened earlier and solves one more issue) and the PR to move forward with #456

BassCoder2808 avatar Jun 21 '23 21:06 BassCoder2808

@BassCoder2808 - I"m confused this issue is about adding the Github link to the license info page and #452 is about removing the Standard License Header field from the output in the issue, so I think we should leave both issues?

but is it that the PR #456 solves both of these issues?

jlovejoy avatar Jun 22 '23 15:06 jlovejoy

Hi @jlovejoy yes actually #452 the issue which you had created also intended to do the same. Yes, #456 intends to solve both the task which you have mentioned above regarding the "Standard License Header" as well as the "open issue on new tab"

BassCoder2808 avatar Jun 22 '23 17:06 BassCoder2808

was this issue intended to add a link to the Github issue to individual license pages in the tool like https://tools.spdx.org/app/license_requests/251/ or to the list here https://tools.spdx.org/app/license_requests/ ?

I was thinking the latter, but in any case, it is not there, so I don't think this is resolved yet

jlovejoy avatar Jul 13 '23 21:07 jlovejoy

As far as I remember @jlovejoy this was intended to open a new issues tab for that particular issue only because my thinking was that, the user will be focused on the currently submitted license only and not towards the general list

BassCoder2808 avatar Jul 14 '23 06:07 BassCoder2808