spdx-examples icon indicating copy to clipboard operation
spdx-examples copied to clipboard

add Lite profile examples

Open NorioKobota opened this issue 1 year ago • 9 comments

We implemented three samples that show how to use Lite Profile. We would appriciate your review.

NorioKobota avatar Jul 06 '24 03:07 NorioKobota

@JPEWdev Sorry to be late, but we have corrected the points you pointed out, so could you please take a look again? Thank you!

NorioKobota avatar Jul 22 '24 02:07 NorioKobota

@NorioKobota do you mind to move all SPDX JSON files from spdx-3.0/ folder to spdx3.0/ folder please? Thank you

The current workflow is now looking for files in spdx3.0/ (to make is consistent with previous spdx2.0/).

https://github.com/spdx/spdx-examples/blob/6a5d3a00fdc3d2bcdd9bb9959a0aa09c1f9dc801/.github/workflows/pull_request.yml#L74

bact avatar Jan 09 '25 10:01 bact

@bact Sure. I will do it and the rest of the change request. Sorry for the late reply. Thanks!

NorioKobota avatar Jan 09 '25 10:01 NorioKobota

@bact I believe I have fixed everything except dataLicense, could you please review it? Also, is there an example of how to write dataLicense somewhere?

NorioKobota avatar Jan 28 '25 07:01 NorioKobota

Thank you so much for the review. I confirmed and committed your suggestions.

NorioKobota avatar Jan 28 '25 07:01 NorioKobota

Thank you @NorioKobota and @no-ta . I think it's pretty much all good.

Now we need a maintainer to approve the validation workflow - to let it pass the validation before merge.

(Note that I have removed all my suggestions that are already resolved, since they are too long, to make this PR easier to read)

bact avatar Jan 28 '25 08:01 bact

@zvr @goneall if you have some time to approve the workflow (for PR validation ), thank you.

bact avatar Jan 28 '25 08:01 bact

@bact Ah, sorry. https://github.com/spdx/spdx-examples/pull/91#issuecomment-2618083079 I believe I have fixed everything **except dataLicense**. Could someone teach me how to implement?

NorioKobota avatar Jan 28 '25 12:01 NorioKobota

As there were changes in validation workflow/dependencies in April 2025 (and probably also after that), we may like to rerun the check to see if it pass now.

bact avatar Jul 22 '25 08:07 bact