spdx-3-model icon indicating copy to clipboard operation
spdx-3-model copied to clipboard

Make URL clickable.

Open vargenau opened this issue 1 year ago • 7 comments

vargenau avatar Apr 29 '24 16:04 vargenau

In general we need to have

 see https://spdx.org

and not

 see [SPDX](https://spdx.org)

because I think it was a restriction of the ISO standard formatting (IIRC).

But maybe things have evolved; I'll ask around.

zvr avatar Apr 29 '24 20:04 zvr

Nice catch. Another different behavior between MkDocs and GitHub.

GitHub can automatically render this to a clickable link:

https://www.iana.org/

For the same result, MkDocs needs this:

<https://www.iana.org/>

See an example in https://spdx.github.io/spdx-spec/v3.0/model/Core/Datatypes/MediaType/

bact avatar Apr 30 '24 01:04 bact

@zvr @kestewart @bact

So I understand I should replace things like:

[https://spdx.org/licenses/exceptions-index.html](https://spdx.org/licenses/exceptions-index.html)

by

<https://spdx.org/licenses/exceptions-index.html>

What should I do with things like:

[RFC 2046](https://www.ietf.org/rfc/rfc2046.txt) 

Should I remove the link?

We have such kind of links in e.g. https://spdx.github.io/spdx-spec/v3.0/serializations/

(file docs/serializations.md in https://github.com/spdx/spdx-spec)

vargenau avatar May 15 '24 14:05 vargenau

I'd say we pause this one till we know (and test) the exact production process, so that we know what the requirements will be. It makes no sense to make changes now and have to make other changes later.

zvr avatar May 15 '24 16:05 zvr

Agree with @zvr on the pause, the knowledge of production process, and the test.

With that, we should make the knowledge and the test available and accessible more to the spec contributors. (for example, how to set up a local test)

More documentation on how spdx-3-model, spdx-spec, spec-parser, and mkdocs are working together to generate the final spec website are welcome. https://github.com/spdx/spdx-spec/pull/946 is part of the attempt.

bact avatar May 15 '24 17:05 bact

Btw, it is totally understandable that we were not given the priority to such the documentation before this, since we were all focused on the release of 3.0. Now we have less pressure on that.

bact avatar May 15 '24 17:05 bact

So I understand I should replace things like:

[https://spdx.org/licenses/exceptions-index.html](https://spdx.org/licenses/exceptions-index.html)

by

<https://spdx.org/licenses/exceptions-index.html>

@vargenau From the machine point of view, both are valid Markdown and will get rendered perfectly (and identically) with mkdocs.

From the human point of view, the latter is more friendly for the human editor, less cluttered. It is less error-prone as well, because you don't have to worry about misspelling another URL.

What should I do with things like:

[RFC 2046](https://www.ietf.org/rfc/rfc2046.txt) 

If it is the ISO requirement to have the URL in clear (to make the URL visible when printed on paper), then we should expand it.

It can be something like:

RFC 2046 <https://www.ietf.org/rfc/rfc2046.txt>

or in a style according to our style guide (which I'm not sure if we have one).

bact avatar May 15 '24 17:05 bact

So, the final outcome is that we can (and must) have links not showing, like:

see SPDX

which is written as:

 see [SPDX](https://spdx.org/)

and the production process will translate it to footnotes in the ISO standard.

zvr avatar Jul 26 '24 09:07 zvr

All links are already got covered. As time goes by, a change set in this PR eventually got reduced to one, and that link is also got covered, see: https://spdx.github.io/spdx-spec/v3.0.1-draft/model/Core/Datatypes/MediaType/

We can close this PR.

bact avatar Aug 06 '24 15:08 bact

Thank you @vargenau for the PR, as we learn along the process about subtle differences between Markdown renderers.

bact avatar Aug 06 '24 15:08 bact

Closing PR, as links have been handled by other PRs.

kestewart avatar Aug 06 '24 16:08 kestewart