Spdx-Java-Library icon indicating copy to clipboard operation
Spdx-Java-Library copied to clipboard
verified publisher icon spdx

Unexpected behavior comparing SPDX documents with no local LicenseRef text

Open goneall opened this issue 4 years ago • 5 comments

When comparing 2 SPDX documents with a LicenseRef containing no text, the comparison of those LicenseRef's is false, but no explanation is given.

We probably do not want them to match since we don't have the text to compare, but we could list them in the Extracted Licenses tab as EMPTY.

goneall avatar Feb 16 '21 22:02 goneall

This is related to https://github.com/spdx/tools/issues/267

goneall avatar Feb 16 '21 22:02 goneall

Attaching a test file with an empty license text and the resultant compare xlsx spreadsheet when comparing to itself. SPDXTagExample-v2.2-no-text1.spdx.txt result.xlsx

goneall avatar Aug 31 '21 23:08 goneall

I'm going to leave this open for now - not sure if we should match empty text or not.

Note that the Verification tab does show that there is missing required license text.

goneall avatar Aug 31 '21 23:08 goneall

Moving this issue to the Spdx-Java-Library since the fix (if we decide this is a bug) would be in the license compare code in the library.

goneall avatar Aug 31 '21 23:08 goneall

Labeling this as "won't fix" - Since license text is required per spec and the tool, the behavior in matching an invalid SPDX document doesn't need to be defined.

goneall avatar Sep 26 '21 18:09 goneall