serverless-benchmarks icon indicating copy to clipboard operation
serverless-benchmarks copied to clipboard

Sanitize input

Open niranjank2022 opened this issue 2 years ago • 11 comments

This PR addresses issue #118.

Currently, the handler.py files in every benchmark (000 to 500) are modified. Also, formatted strings using .format() are converted to f-strings.

niranjank2022 avatar Aug 04 '23 09:08 niranjank2022

Hello @mcopik ! I would like to hear from you whether I have done the first part correctly or if I have to revert anything.

niranjank2022 avatar Aug 04 '23 09:08 niranjank2022

@mcopik I don't know how to deploy the benchmarks in aws. I need assistance with that.

niranjank2022 avatar Aug 24 '23 09:08 niranjank2022

@mcopik I don't know how to deploy the benchmarks in aws. I need assistance with that.

Meanwhile, I tried launching the benchmarks locally in minio storage. I noticed that whenever we launch the Docker containers for the benchmarks using this command - ./sebs.py local start 110.dynamic-html test out_benchmark.json --config config/local_deployment.json --deployments 1 it modifies the out_benchmark.json. Input object is generated with a default value for each benchmark. I copy pasted that input as data to invoke the function. My doubt, is this the propriety way to test locally?

And while doing this, I observed that the benchmarks 020, 030 and 040 returned status: 'failure'. and 311 returned error. I wanted to bring this to your notice.

niranjank2022 avatar Aug 24 '23 10:08 niranjank2022

@mcopik I don't know how to deploy the benchmarks in aws. I need assistance with that.

Meanwhile, I tried launching the benchmarks locally in minio storage. I noticed that whenever we launch the Docker containers for the benchmarks using this command - ./sebs.py local start 110.dynamic-html test out_benchmark.json --config config/local_deployment.json --deployments 1 it modifies the out_benchmark.json. Input object is generated with a default value for each benchmark. I copy pasted that input as data to invoke the function. My doubt, is this the propriety way to test locally?

And while doing this, I observed that the benchmarks 020, 030 and 040 returned status: 'failure'. and 311 returned error. I wanted to bring this to your notice.

And I did some changes for incorporating jsonschema in requirements.txt. When I try to push my code, I am getting this warning:

remote: Permission to niranjank2022/serverless-benchmarks.git denied to niranjank2022.
fatal: unable to access 'https://github.com/niranjank2022/serverless-benchmarks.git/': The requested URL returned error: 403

Could you please help me resolve this?

niranjank2022 avatar Aug 24 '23 10:08 niranjank2022

@mcopik I don't know how to deploy the benchmarks in aws. I need assistance with that.

Meanwhile, I tried launching the benchmarks locally in minio storage. I noticed that whenever we launch the Docker containers for the benchmarks using this command - ./sebs.py local start 110.dynamic-html test out_benchmark.json --config config/local_deployment.json --deployments 1 it modifies the out_benchmark.json. Input object is generated with a default value for each benchmark. I copy pasted that input as data to invoke the function. My doubt, is this the propriety way to test locally?

And while doing this, I observed that the benchmarks 020, 030 and 040 returned status: 'failure'. and 311 returned error. I wanted to bring this to your notice.

@niranjank2022 Correct - these are internal microbenchmarks that will not work outside of an experiment. I need to update the documentation for that.

Launching locally looks correct as long as you get a proper HTTP response- :)

EDIT: What error do you observe on benchmark 311? This one shouldn't fail.

mcopik avatar Sep 05 '23 15:09 mcopik

@mcopik I don't know how to deploy the benchmarks in aws. I need assistance with that.

@niranjank2022 There is documentation on configuring the AWS account. Once you do that, you can just run ./sebs.py benchmark invoke .... Everything benchmarks need for execution should be covered by AWS Free Tier.

Can you please elaborate on which of these steps are failing for you or if you don't know how to start with them?

https://github.com/spcl/serverless-benchmarks/blob/master/docs/platforms.md

mcopik avatar Sep 05 '23 15:09 mcopik

And I did some changes for incorporating jsonschema in requirements.txt. When I try to push my code, I am getting this warning:

remote: Permission to niranjank2022/serverless-benchmarks.git denied to niranjank2022.
fatal: unable to access 'https://github.com/niranjank2022/serverless-benchmarks.git/': The requested URL returned error: 403

Could you please help me resolve this?

This seems like a problem with your local git configuration: maybe replacing the address from https:// to [email protected] could help.

mcopik avatar Sep 05 '23 15:09 mcopik

And I did some changes for incorporating jsonschema in requirements.txt. When I try to push my code, I am getting this warning:

remote: Permission to niranjank2022/serverless-benchmarks.git denied to niranjank2022.
fatal: unable to access 'https://github.com/niranjank2022/serverless-benchmarks.git/': The requested URL returned error: 403

Could you please help me resolve this?

This seems like a problem with your local git configuration: maybe replacing the address from https:// to [email protected] could help.

I resolved this problem of mine. I used Personal tokens with certain scopes.

niranjank2022 avatar Sep 18 '23 18:09 niranjank2022

@niranjank2022 Hi! Do you plan to continue working on this PR? IIRC, it has not been tested on AWS?

mcopik avatar May 13 '24 14:05 mcopik

@niranjank2022 Hi! Do you plan to continue working on this PR? IIRC, it has not been tested on AWS?

I am extremely sorry @mcopik. I got into some serious health problems and because of that, I have not got any time to work on Opensource. I will be mostly back by next month. Is it possible that I can continue from where I left off next month?

niranjank2022 avatar May 13 '24 14:05 niranjank2022

@niranjank2022 Sure, no worries! Let me know if you have any questions.

mcopik avatar May 13 '24 14:05 mcopik