laravel-permission icon indicating copy to clipboard operation
laravel-permission copied to clipboard

Wrong octane event listener

Open giunashvili opened this issue 1 year ago • 1 comments

https://github.com/spatie/laravel-permission/blob/0e593bb9e6808cc55c67f150878b0847f20b9036/src/PermissionServiceProvider.php#L108-L112

In octane there is no \Laravel\Octane\Events\OperationTerminated event. there is Laravel\Octane\Contracts\OperationTerminated event.

image

Permissions cleanup won't work like this.

giunashvili avatar Feb 05 '24 11:02 giunashvili

You are right, first was Events\RequestTerminated, then it was changed to OperationTerminated, but events remained

erikn69 avatar Feb 05 '24 13:02 erikn69

no update on this? its buggy on octane with ->can('...') or middleware('permission:...') after modify role-permission. changing \Laravel\Octane\Events\OperationTerminated to \Laravel\Octane\Contracts\OperationTerminated works.

dinyo avatar Apr 18 '24 09:04 dinyo