holidays icon indicating copy to clipboard operation
holidays copied to clipboard

Add Moroccan Holidays

Open YazidKHALDI opened this issue 1 year ago • 2 comments

This pull request enhances the support for Moroccan national holidays Note:

  • Islamic holidays' dates are subject to change based on the Hijri calendar, and efforts will be made to ensure accurate and up-to-date information in subsequent releases.

Do I have the right to use geniusts/hijri-dates to convert Date convert Gregorian date to Hijri date and vice versa? I will try to test it today to check how much it's accurate

YazidKHALDI avatar Jan 18 '24 00:01 YazidKHALDI

I've created a new PR #186, (originally #63), in which I've added a Hijri Calendar trait that we can use geniusts/hijri-dates to calculate Hijri dates.

ahmedmansoor avatar Jan 27 '24 17:01 ahmedmansoor

@Nielsvanpach HI Niels I hope you're doing well. I've made some updates to the project, , I've removed the dependency on the geniusts/hijri-dates package and integrated the calculation function provided by the Ministry of Endowments and Islamic Affairs in Morocco .

This change simplifies the codebase and reduces external dependencies,

thank you

YazidKHALDI avatar Mar 11 '24 02:03 YazidKHALDI