holidays icon indicating copy to clipboard operation
holidays copied to clipboard

Published 20 hours ago • verified publisher icon spatie

Add South African holidays

Open johanmeiring opened this issue 1 year ago • 3 comments

This PR adds South African public holidays, taking into account the law which states that if a public holiday lands on a Sunday then it is also observed the following Monday.

johanmeiring avatar Jan 17 '24 19:01 johanmeiring

Thanks! Could you rebase on main, so I can run the tests?

Also, there seems to be 2 PRs for South Africa. Might be best if you worked together on 1 PR: https://github.com/spatie/holidays/pull/32

Nielsvanpach avatar Jan 18 '24 14:01 Nielsvanpach

Hi @Nielsvanpach ! I've rebased as requested. As for the other PR... what a coincidence, and implementations seem to be nearly identical. How would you propose we both work on the same PR? Or I suppose you could just merge whichever one ends up being ready first or looks best to you? (I don't mind at all either way)

johanmeiring avatar Jan 18 '24 14:01 johanmeiring

Yeah! South Africa represented! Nice one @johanmeiring 🎉🎉🎉🎉🎉💪💪💪

JonathanAspeling avatar Jan 19 '24 19:01 JonathanAspeling

Closing in favour of #30

johanmeiring avatar Jan 20 '24 16:01 johanmeiring