holidays icon indicating copy to clipboard operation
holidays copied to clipboard

Add 🇽🇰Kosovo🇽🇰 Holidays

Open AvdylKrasniqi opened this issue 1 year ago • 1 comments

TODO: Implement Islamic Holidays

AvdylKrasniqi avatar Jan 20 '24 19:01 AvdylKrasniqi

@Nielsvanpach @thecaliskan @alphaolomi @amralsaleeh @ddouble-d @shoxrux1996 @captainjaypee01 @kakajansh I saw you were involved from other PR about the Islamic Holidays, so I am tagging you here! Perhaps we should all come with a common method in the Country class, so every country can call the method.

AvdylKrasniqi avatar Jan 20 '24 20:01 AvdylKrasniqi

@Nielsvanpach @thecaliskan @alphaolomi @amralsaleeh @ddouble-d @shoxrux1996 @captainjaypee01 @kakajansh I saw you were involved from other PR about the Islamic Holidays, so I am tagging you here! Perhaps we should all come with a common method in the Country class, so every country can call the method.

there is one in this PR #51 that implements the islamic calendar

ddouble-d avatar Jan 21 '24 10:01 ddouble-d

@Nielsvanpach @thecaliskan @alphaolomi @amralsaleeh @ddouble-d @shoxrux1996 @captainjaypee01 @kakajansh I saw you were involved from other PR about the Islamic Holidays, so I am tagging you here! Perhaps we should all come with a common method in the Country class, so every country can call the method.

there is one in this PR #51 that implements the islamic calendar

I think we should implement a common method for all countries that do have Islamic holidays. On the PR #51 the solution is specifically for Malaysia

AvdylKrasniqi avatar Jan 21 '24 20:01 AvdylKrasniqi

Every year the celebration of ramadan and sacrifice holiday's dates are different in Turkey and even inside of the other Islamic countries that's why it's impossible to calculate because the countries are releasing the holiday dates six month ahead not years before.

thecaliskan avatar Jan 21 '24 20:01 thecaliskan

Every year the celebration of ramadan and sacrifice holiday's dates are different in Turkey and even inside of the other Islamic countries that's why it's impossible to calculate because the countries are releasing the holiday dates six month ahead not years before.

I'm with you 💯

amralsaleeh avatar Jan 21 '24 20:01 amralsaleeh

So, Is there anything new?

amralsaleeh avatar Jan 23 '24 14:01 amralsaleeh

In case you want to add multi language support: https://github.com/spatie/holidays/tree/main/lang

Nielsvanpach avatar Jan 24 '24 15:01 Nielsvanpach