eloquent-sortable icon indicating copy to clipboard operation
eloquent-sortable copied to clipboard

Readme is inconsistent.

Open TheFehr opened this issue 2 years ago • 0 comments

Before just opening a PR to fix it.

Is this

/** * the record for model id 3 will have order_column value 11 * the record for model id 1 will have order_column value 12 * the record for model id 2 will have order_column value 13 */ MyModel::setNewOrder([3,1,2], 10);

and this

/** * the record for model uuid '7a051131-d387-4276-bfda-e7c376099715' will have order_column value 10 * the record for model uuid '40324562-c7ca-4c69-8018-aff81bff8c95' will have order_column value 11 * the record for model uuid '5dc4d0f4-0c88-43a4-b293-7c7902a3cfd1' will have order_column value 12 */ MyModel::setNewOrderByCustomColumn('uuid', [ '7a051131-d387-4276-bfda-e7c376099715', '40324562-c7ca-4c69-8018-aff81bff8c95', '5dc4d0f4-0c88-43a4-b293-7c7902a3cfd1' ], 10);

correct?

Because both receive 10 as second argument but one starts at 10 and one at 11?

TheFehr avatar May 23 '22 09:05 TheFehr