calendar-links
calendar-links copied to clipboard
Use http_build_query vs concat strings + traits vs inheritance ?
What do you want to achieve?
Please check Package principles before you create a request.
Hi, while working on https://github.com/spatie/calendar-links/pull/192 I had experimented with using http_build_query
in https://github.com/vever001/calendar-links/commit/39a9bbd22ceb0da9dc4f93bef6286324d9a48dba
It URL-encodes all params but as I recall it doesn't break anything.
The inheritance for outlook generators was also replaced with a trait.
This is just an issue to discuss whether it is worth pursuing or not. Let me know :)