nbsphinx icon indicating copy to clipboard operation
nbsphinx copied to clipboard

Update default version of require.js

Open kasium opened this issue 2 months ago • 4 comments

Closes #851

kasium avatar Nov 11 '25 07:11 kasium

Thanks for this PR!

Sadly, it doesn't seem to work, see the rendered documentation of "widgets": https://nbsphinx--853.org.readthedocs.build/en/853/code-cells.html#Interactive-Widgets-(HTML-only)

There's an error in the JavaScript console that's probably related:

Uncaught ReferenceError: define is not defined
    <anonymous> https://cdn.jsdelivr.net/npm/@jupyter-widgets/html-manager@^1.0.1/dist/embed-amd.js:2

mgeier avatar Nov 11 '25 19:11 mgeier

Good point, I'm not an expert in this area. For the issue raised in my project updating require.js was the solution. I'm also confused that a patch level increase can cause this issue. Let me check the changelog

kasium avatar Nov 11 '25 19:11 kasium

Mhm, there is no changelog and the changes don't look related: https://github.com/requirejs/requirejs/compare/2.3.4...2.3.7

However when lookin into other PRs like https://github.com/spatialaudio/nbsphinx/pull/849 I think your CI is broken :-)

kasium avatar Nov 11 '25 19:11 kasium

However when lookin into other PRs like #849 I think your CI is broken :-)

Yes, see #844, help is always welcome.

But this should be independent, right?

mgeier avatar Nov 11 '25 19:11 mgeier