openinbrowser icon indicating copy to clipboard operation
openinbrowser copied to clipboard

Published 20 hours ago • verified publisher icon spasche

Dialog cuts buttons

Open alexolog opened this issue 10 years ago • 18 comments

See http://tinypic.com/view.php?pic=2i9361e&s=8 Running FF30 with Classic Theme Restorer

alexolog avatar Jun 12 '14 17:06 alexolog

I tried to reproduce on Windows 8.1 with Firefox 30 by installing Open in Browser, FlashGot and Classic Theme Restorer, but the dialog looks fine for me: capture

What's your operating system?

spasche avatar Jun 18 '14 21:06 spasche

On 2 different machines: WinXP/SP3 and Win7

Perhaps there's a conflict with OpenDownload2? https://addons.mozilla.org/en-US/firefox/addon/opendownload-10902/

alexolog avatar Jun 18 '14 22:06 alexolog

I - as the author of OpenDownload2 - actually doubt that my extension fails, the only cases where there were major layout issues were always related to Open In Browser. Does your extension maybe resize the dialog?

dertuxmalwieder avatar Jun 19 '14 06:06 dertuxmalwieder

The extension doesn't resize the dialog. I couldn't reproduce on a Windows 7 vm, with a few extensions loaded. I can suggest that you try with a new clean profile, and add your extensions one by one until you see the problem happen. Then you can determine which extension is responsible.

capture

spasche avatar Jun 19 '14 18:06 spasche

Try with an executable to actually trigger the [Run] button

alexolog avatar Jun 20 '14 04:06 alexolog

Ok, I can reproduce if I only keep FlashGot and Open in Browser. capture

Apparently the dialog adapts to the content, but sometimes it is not tall enough. FlashGot doesn't seem to set the height explicitly. I don't know why the dialog isn't auto-sized properly, maybe that's because some elements are added dynamically after the dialog is rendered.

Who is responsible and what the fix should be? Not sure about that. If someone has a good idea and a patch or pull request that's welcome ;-).

spasche avatar Jun 20 '14 17:06 spasche

Maybe check position/size of the "OK" button and compare them to the dimensions of the window?

dertuxmalwieder avatar Jun 20 '14 18:06 dertuxmalwieder

Yeah, that could be an option. Care should be take to do the resizing after all other extensions have populated the dialog (using a timeout with some polling for instance).

Honestly I don't think I'll have time to implement this in the near future (and as I'm not using FlashGot that's not high on my todo list). If someone wants to tackle this, I'm happy to give directions.

spasche avatar Jun 20 '14 18:06 spasche

I'm busy investigating about OD² 4.0's missing SeaMonkey compatibility, so I can't really help. :/

dertuxmalwieder avatar Jun 20 '14 19:06 dertuxmalwieder

Sure, no problem. I wasn't implying that you should implement it ;-)

spasche avatar Jun 20 '14 19:06 spasche

Maybe talk to FlashGot's author?

alexolog avatar Jun 21 '14 01:06 alexolog

Is there some progress on this?

alexolog avatar Mar 04 '15 17:03 alexolog

I haven't fiddled with it yet. Should I (have to)?

dertuxmalwieder avatar Apr 20 '15 23:04 dertuxmalwieder

Please do!

alexolog avatar Apr 20 '15 23:04 alexolog

Damn :(

dertuxmalwieder avatar Apr 21 '15 00:04 dertuxmalwieder

Cookie? http://www.chick-fil-a.com/Media/Img/catalog/Food/XLarge/Cookie.png

alexolog avatar Apr 21 '15 00:04 alexolog

Appreciated!

dertuxmalwieder avatar Apr 21 '15 00:04 dertuxmalwieder

The cookie is getting stale...

alexolog avatar Jun 19 '15 03:06 alexolog