simplemde-markdown-editor icon indicating copy to clipboard operation
simplemde-markdown-editor copied to clipboard

FontAwesome 5 compatibility

Open Ionaru opened this issue 6 years ago • 4 comments

Added compatibility for FontAwesome 5 by creating a seperate element for the icon and nesting it inside the button element instead of putting the classes on the button element. This makes sure that the button and all its properties stays intact when FontAwesome 5 changes elements to <svg> for their icons.

FontAwesome 4 works with this change as well. There are no visual differences except that the icon has shifted 1px up, probably because of some centering by FontAwesome.

Fixes #664

Ionaru avatar Dec 04 '17 10:12 Ionaru

Need plz !

johndodev avatar Jan 23 '18 22:01 johndodev

This has been implemented in my fork of the project: https://github.com/Ionaru/easy-markdown-editor

Ionaru avatar Jan 24 '18 09:01 Ionaru

Any chance this could be added in?

Jetski5822 avatar Aug 17 '18 07:08 Jetski5822

Is there anyone who wants to co-maintain this package? I've pinged the original authors to see if they need help but my expertise is in other languages so would appreciate backup.

atodorov avatar Nov 08 '18 21:11 atodorov