nokogiri icon indicating copy to clipboard operation
nokogiri copied to clipboard

Published 20 hours ago • verified publisher icon sparklemotion

Fix namespace reparenting issue #2494.

Open TreyE opened this issue 2 years ago • 5 comments

What problem is this PR intended to solve?

This PR is intended to address #2494, issues with the reparenting of nodes with prefix collisions.

Closes #2494

Have you included adequate test coverage?

I've added a test as part of the namespace testing under test/xml/test_namespace.rb.

Does this change affect the behavior of either the C or the Java implementations?

C implementations are corrected, the java implementation does not suffer from this issue (tests pass correctly with no code change).

TreyE avatar Apr 03 '22 15:04 TreyE

I've kicked off CI.

flavorjones avatar Apr 05 '22 12:04 flavorjones

I've rebased onto current main

flavorjones avatar Aug 28 '22 17:08 flavorjones

Looks like this PR breaks some downstream users of Nokogiri. Would you be able to take a look at what's going on there, please?

  • https://github.com/sparklemotion/nokogiri/runs/8059235811?check_suite_focus=true
  • https://github.com/sparklemotion/nokogiri/runs/8059235851?check_suite_focus=true

flavorjones avatar Aug 28 '22 18:08 flavorjones

I think I might be able to take a look, yeah. Let me see which ones get broken. I couldn't find any breaks in the main tests but maybe I didn't run some.

TreyE avatar Sep 05 '22 00:09 TreyE