spark-jobserver icon indicating copy to clipboard operation
spark-jobserver copied to clipboard

replace akka-app with kamon jvm metrics

Open hntd187 opened this issue 8 years ago • 2 comments

As per @velvia suggestion in gitter, I think kamon would be fantastic because it gives a lot of the tracing and such that we are looking for and I think with the context-per-jvm functionality we should definitely look to have this implemented there. It will also allow us to get rid of the old akka-app portion of the code.

With that in mind, I once many moons ago upgraded yammer metrics to drop wizard metrics, but that branch is my "break the world" branch so trying to take what I did out of it would probably be a horrible horrible rebase.

So here is my plan to accomplish this

  1. Remove the akka-app from the current code
  2. Implement all the old metrics using kamon
  3. Ensure same functionality to our previous metrics
  4. Implement the aspectj features where/if necessary as optional things for people to add as they see fit
  5. Perhaps offer another artifact for those aspectj metrics
  6. Maybe allow for custom metrics in spark jobs? (Perhaps functionality for the future)
  7. ???
  8. Profit!

I think 1-4 should be straight forward since I know already what I'm doing, the rest we should discuss.

Related Links: http://kamon.io/

hntd187 avatar Jun 22 '16 12:06 hntd187

hey guys! If you need some help from the Kamon team (@dpsoft and me) to make this real just let us know :).

ivantopo avatar Jun 22 '16 17:06 ivantopo

@dpsoft that would be pretty awesome actually!!

-Evan "Never doubt that a small group of thoughtful, committed citizens can change the world" - M. Mead

On Jun 22, 2016, at 10:02 AM, Ivan Topolnjak [email protected] wrote:

hey guys! If you need some help from the Kamon team (@dpsoft and me) to make this real just let us know :).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

velvia avatar Jun 22 '16 17:06 velvia