Robyn icon indicating copy to clipboard operation
Robyn copied to clipboard

Published 20 hours ago • verified publisher icon sparckles

fix: json decode bug

Open asamaayako opened this issue 1 year ago • 7 comments

Description

This PR fixes #816 , and it a retry PR.

Summary

This PR is try again. I'm having a conflict, and retrying met a can't pass banchmark😥. Maybe I need help to Pass test. Define a function for processing json_string to PyObject

PR Checklist

Please ensure that:

  • [x] The PR contains a descriptive title
  • [x] The PR contains a descriptive summary of the changes
  • [x] You build and test your changes before submitting a PR.
  • [x] You have added relevant documentation
  • [x] You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

asamaayako avatar Aug 29 '24 12:08 asamaayako

@asamaayako is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 29 '24 12:08 vercel[bot]

CodSpeed Performance Report

Merging #955 will not alter performance

Comparing asamaayako:fix/json_decode (1f5465e) with main (12d8c0b)

Summary

✅ 114 untouched benchmarks

codspeed-hq[bot] avatar Aug 29 '24 12:08 codspeed-hq[bot]

Hey @asamaayako 👋

Could you explain the confilct you are facing? I will be happy to help :D

sansyrox avatar Aug 29 '24 19:08 sansyrox

Hey @asamaayako 👋

Could you explain the confilct you are facing? I will be happy to help :D

Hey @sansyrox Previously encountered a conflict, merge conflict (failed to pass test after merging the main branch into this branch). I think at the time the main branch had code that couldn't pass test. So I force push rolled back the merge. Now it ok :D. This PR is ready to merge I think.

asamaayako avatar Aug 30 '24 01:08 asamaayako

Hey @VishnuSanal ,

Could you review this PR?

sansyrox avatar Oct 06 '24 12:10 sansyrox

Hey @asamaayako 👋 Could you explain the confilct you are facing? I will be happy to help :D

Hey @sansyrox Previously encountered a conflict, merge conflict (failed to pass test after merging the main branch into this branch). I think at the time the main branch had code that couldn't pass test. So I force push rolled back the merge. Now it ok :D. This PR is ready to merge I think.

@asamaayako , thanks for the PR. Apologies for the super late acknowledgment. Having a look now

sansyrox avatar Oct 06 '24 12:10 sansyrox

😱 Found 2 issues. Time to roll up your sleeves! 😱

recurseml[bot] avatar May 27 '25 19:05 recurseml[bot]