Robyn icon indicating copy to clipboard operation
Robyn copied to clipboard

Binary type Reponse causes a crash

Open goSeeFuture opened this issue 7 months ago • 1 comments

Bug Description

I use Robyn to write the Export Excel function, which works fine with very early versions and always crashes when updated to recent versions. I read the rust code and found that Response does a Utf8 conversion of all returned data was the cause of the crashes, then I tried to tweak the code (not knowing rust at all, AI and PyO3 docs) to differentiate between text, binary description Luckily the crashes disappeared!

I guessed the type of Response data by Content-Type, but there are so many MIME-Types that I thought maybe only guessing on the most common types to determine and allow users to register if the MIME-Type they use is a Text type ......

These are some of my attempts to fix this problem, I hope to get an official fix, and I wish Robyn is getting better and better, I really like it too much.

Steps to Reproduce

  1. response Content-Type: application/vnd.openxmlformats-officedocument.spreadsheetml.sheet data

Your operating system

Linux

Your Python version (python --version)

3.11

Your Robyn version

latest

Additional Info

No response

goSeeFuture avatar Jun 28 '24 12:06 goSeeFuture